I have built a few from empty propane cylnders , I like the coleman camping size
I care fully grind/peel off the sheet metal bottom to reveal a nice round end and then cut off the threaded neck
I use a torch and brazeing rods as it flows nicely on this gauge of metal
For the fuel line nipple I use a piece of large steel brake line just drill a hole where you want it and push it thru with enough inside that it will not pick up sediment from the bottom of the tank
My trick for the fuel cap is too buy a small metal can of ABS plumbing cement
I cut the bottom out off the can and then use a hole saw to cut a clean round hole in the top of the tank
The bottomless can will slide down in with a nice snug fit and acts as a anti-slosh baffle
Braze it in and build a nice fillet around the neck , sometimes I use Jb weld as a filler to pretty it up
Drill a small vent hole in the cap and cut a gasket out of a plastic icecream lid with a offset vent hole and your good tol go
This is the only picture I can find of mine but have to buuild another soon , might do a build thread on it